MenuItem: Add Storybook stories #53613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangank36
force-pushed
the
storybook/menu-item
branch
from
4819782
to
e28c505
Compare
mirka
added
[Type] Developer Documentation
mirka
reviewed
Aug 18, 2023
mirka
reviewed
Aug 18, 2023
Add more stories for menu-item Update MenuItem import index.story.tsx Update packages/components/src/menu-item/index.tsx Co-authored-by: Lena Morita <lena@jaguchi.com>
bangank36
force-pushed
the
storybook/menu-item
branch
from
10a6e61
to
7edfb4d
Compare
mirka
reviewed
Aug 24, 2023
mirka
reviewed
Aug 24, 2023
Co-authored-by: Lena Morita <lena@jaguchi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add missing story for MenuItem Component
Why?
Missing stories for components has been discussed on #36128 (comment), MenuItem has been migrated to Typescript already and its time to add missing stories
How?
Add new /stories folder on /menu-item
Testing Instructions
npm run storybook:dev?path=/docs/components-menuitem--docsTesting Instructions for Keyboard
Screenshots or screencast